fix: use DirectoryStream to prevent failure on invalid utf-8 filenames #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can create invalid file using `touch "$(echo -e '\xEB\xEE\xE2\xE0\xF0\xE8')"` Unfortunately in Lollipop ang higher ART is used, and it can't handle some symbols - https://stackoverflow.com/a/34282026 There is not many options to read directory files, and another option only available on Oreo and higher - use DirectoryStream, which will not throw exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can create invalid file using
touch "$(echo -e '\xEB\xEE\xE2\xE0\xF0\xE8')"Unfortunately in Lollipop ang higher ART is used, and it can't handle some symbols - https://stackoverflow.com/a/34282026
There is not many options to read directory files, and another option only available on Oreo and higher - use DirectoryStream, which will not throw exception